From d28425064c17115e56b41e3d073f8a6c653c3bcb Mon Sep 17 00:00:00 2001 From: Martin Tournoij Date: Sat, 15 Oct 2022 22:54:04 +0200 Subject: [PATCH] Don't return in collect test helper on errors Would return without calling close, so on errors you'd get a meaningless "event stream was not closed after 1s": --- FAIL: TestWatchRm (0.00s) --- FAIL: TestWatchRm/remove_watched_directory (2.43s) helpers_test.go:384: fsnotify.sendDirectoryChangeEvents: open /tmp/TestWatchRmremove_watched_directory2304249565/001: no such file or directory helpers_test.go:354: event stream was not closed after 1s --- helpers_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/helpers_test.go b/helpers_test.go index 22bb6df..7f1de52 100644 --- a/helpers_test.go +++ b/helpers_test.go @@ -382,7 +382,6 @@ func (w *eventCollector) collect(t *testing.T) { return } t.Error(e) - return case e, ok := <-w.w.Events: if !ok { w.done <- struct{}{} -- 2.50.1