From b0b98e9fb665db6bd6a99b0fe3fa5d4b7744c3a5 Mon Sep 17 00:00:00 2001 From: Martin Tournoij Date: Thu, 9 Feb 2023 15:31:23 +0100 Subject: [PATCH] Update CI to Go 1.17 - 1.20 (#557) I have no idea if anyone is using Go 1.16 with fsnotify. Go 1.16 (released August 2021) became mandatory with v1.5.1 (August 2021). Go 1.17 was released just a few days before it was tagged. Some people did experience problems (#400), but overall the feedback was limited. So based on this, I think it's probably safe to just follow the Go release policy: "Each major Go release is supported until there are two newer major releases." This will allow merging #554 --- .github/workflows/build.yml | 2 +- .github/workflows/test.yml | 8 ++++---- CHANGELOG.md | 1 + go.mod | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 74048fb..c1605a7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,7 +10,7 @@ jobs: strategy: fail-fast: false matrix: - go: ['1.16', '1.19'] + go: ['1.17', '1.20'] runs-on: ubuntu-latest steps: - name: setup Go diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 98b86ea..ad3bbde 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,8 +15,8 @@ jobs: - ubuntu-latest - windows-latest go: - - '1.16' - - '1.19' + - '1.17' + - '1.20' runs-on: ${{ matrix.os }} steps: - name: setup Go @@ -46,7 +46,7 @@ jobs: # Test only the latest Go version on macOS; we use the macOS builders for BSD # and illumos, and GitHub doesn't allow many of them to run concurrently. If - # it works on Windows and Linux with Go 1.16, then it probably does on macOS + # it works on Windows and Linux with Go 1.17, then it probably does on macOS # too. testMacOS: name: test @@ -57,7 +57,7 @@ jobs: - macos-11 - macos-12 go: - - '1.19' + - '1.20' runs-on: ${{ matrix.os }} steps: - name: setup Go diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e08ba5..362e81d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ Unreleased ---------- +This version of fsnotify needs Go 1.17. ### Additions diff --git a/go.mod b/go.mod index 220ed74..e32c1c6 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/fsnotify/fsnotify -go 1.16 +go 1.17 require golang.org/x/sys v0.0.0-20220908164124-27713097b956 -- 2.50.1