]> go.fuhry.dev Git - fsnotify.git/log
fsnotify.git
12 years agoFixed symlink notifications on Linux
Tudor Golubenco [Thu, 9 May 2013 16:55:29 +0000 (16:55 +0000)]
Fixed symlink notifications on Linux

The linux code used to ignore events on the files that os.Stat reports as
non existing. This ignores the CREATEion of broken links, but monitoring
those can be useful, for example /proc/<pid>/fd/ contains fake links
for all sockets.

The patch simply replaces os.Stat with os.Lstat to solve the issue.

I updated the fsnotify_symlink_test.go to what I consider the correct
behavior but unfortunately couldn't test under windows, so I'm not sure
if it breaks the test there or not.

12 years agoMerge pull request #40 from ChrisBuchholz/master
Chris Howey [Mon, 8 Apr 2013 01:33:26 +0000 (18:33 -0700)]
Merge pull request #40 from ChrisBuchholz/master

watch all file events on files inside folder being watched

12 years agowatch all file events on files inside folder being watched
Christoffer Buchholz [Sun, 7 Apr 2013 23:51:04 +0000 (01:51 +0200)]
watch all file events on files inside folder being watched

12 years agoBSD - Some internal watch flag cleanup
Chris Howey [Thu, 14 Mar 2013 01:31:43 +0000 (20:31 -0500)]
BSD - Some internal watch flag cleanup

12 years agoLinux - Fixes issue #36
Chris Howey [Wed, 13 Mar 2013 23:47:20 +0000 (18:47 -0500)]
Linux - Fixes issue #36

12 years agoMerge branch 'issue-33'
Chris Howey [Tue, 12 Mar 2013 00:09:37 +0000 (19:09 -0500)]
Merge branch 'issue-33'

Fix issue #33

12 years agogo.exp travis-ci
Chris Howey [Mon, 11 Mar 2013 23:32:02 +0000 (18:32 -0500)]
go.exp travis-ci

12 years agoRemove skip test
Chris Howey [Mon, 11 Mar 2013 23:29:07 +0000 (18:29 -0500)]
Remove skip test

12 years agoCommited to go.exp
Chris Howey [Mon, 11 Mar 2013 23:26:37 +0000 (18:26 -0500)]
Commited to go.exp

https://codereview.appspot.com/7497045
https://code.google.com/p/go/issues/detail?id=4068

12 years agoWhen adding files of directory, use fsnFlags from directory.
Chris Howey [Mon, 11 Mar 2013 21:29:55 +0000 (16:29 -0500)]
When adding files of directory, use fsnFlags from directory.

Fixes issue #33

12 years agoAuthors
Chris Howey [Fri, 8 Feb 2013 02:10:13 +0000 (20:10 -0600)]
Authors

12 years agoMutex for map access on Windows
Chris Howey [Thu, 7 Feb 2013 04:48:47 +0000 (22:48 -0600)]
Mutex for map access on Windows

12 years agoMutex for map access on Linux
Chris Howey [Thu, 7 Feb 2013 04:22:29 +0000 (22:22 -0600)]
Mutex for map access on Linux

12 years agoFix tests for Windows : '\\' and '/' path seperators
Chris Howey [Thu, 7 Feb 2013 04:01:39 +0000 (22:01 -0600)]
Fix tests for Windows : '\\' and '/' path seperators

12 years agomutex
Chris Howey [Thu, 7 Feb 2013 03:45:39 +0000 (21:45 -0600)]
mutex

12 years agoMutex used on all OSs
Chris Howey [Thu, 7 Feb 2013 03:43:44 +0000 (21:43 -0600)]
Mutex used on all OSs

12 years agoFix travis-ci
Chris Howey [Thu, 7 Feb 2013 03:04:23 +0000 (21:04 -0600)]
Fix travis-ci

12 years agoFixed unlock for watching directory
Chris Howey [Thu, 7 Feb 2013 02:55:39 +0000 (20:55 -0600)]
Fixed unlock for watching directory

12 years agoMerge branch 'issue-29' of https://github.com/fsouza/fsnotify into race
Chris Howey [Thu, 7 Feb 2013 02:50:51 +0000 (20:50 -0600)]
Merge branch 'issue-29' of https://github.com/fsouza/fsnotify into race

12 years agoMerge pull request #30 from fsouza/mkdir-error-report
Chris Howey [Wed, 6 Feb 2013 23:37:02 +0000 (15:37 -0800)]
Merge pull request #30 from fsouza/mkdir-error-report

tests: fix error reporting from Mkdir calls

12 years agotests: fix data races
Francisco Souza [Wed, 6 Feb 2013 21:18:54 +0000 (19:18 -0200)]
tests: fix data races

go test -race does not report any data races in darwin anymore. I still
need to check Linux.

Related to #29.

12 years agofsnotify_bsd: fix for some data races
Francisco Souza [Wed, 6 Feb 2013 19:11:17 +0000 (17:11 -0200)]
fsnotify_bsd: fix for some data races

All data races detected in tests, that happens in fsnotify_bsd file are
now fixed. I still need to fix data races in tests.

Related to #29.

12 years agotest: fix if expression
Francisco Souza [Wed, 6 Feb 2013 19:05:58 +0000 (17:05 -0200)]
test: fix if expression

12 years agotests: fix error reporting from Mkdir calls
Francisco Souza [Wed, 6 Feb 2013 19:02:58 +0000 (17:02 -0200)]
tests: fix error reporting from Mkdir calls

Whenever the creation of a directory fails, it was trying to report an
error from an outer scope.

12 years agoMerge pull request #28 from Pursuit92/master
Chris Howey [Thu, 10 Jan 2013 01:26:36 +0000 (17:26 -0800)]
Merge pull request #28 from Pursuit92/master

Fix Windows Filepath Separators

12 years agofixed windows path separator
Pursuit92 [Thu, 10 Jan 2013 00:43:11 +0000 (19:43 -0500)]
fixed windows path separator

12 years agoAdd license
Chris Howey [Mon, 17 Dec 2012 20:32:53 +0000 (14:32 -0600)]
Add license

13 years agoBSD - remove merging of flags. remove deleted check in sendDirectoryChangeEvents
Kelvin Fo [Sat, 10 Nov 2012 01:19:54 +0000 (09:19 +0800)]
BSD - remove merging of flags. remove deleted check in sendDirectoryChangeEvents

Remove the unnecessary merging of flags when watching an existing
file/dir since the flags passed is already merged

Remove deleted path check in sendDirectoryChangeEvents. Instead we check
for directory existence before passing to sendDirectoryChangeEvents

13 years agoBSD - support for recursivable watching of subfolders
Kelvin Fo [Tue, 6 Nov 2012 23:27:58 +0000 (07:27 +0800)]
BSD - support for recursivable watching of subfolders

13 years agoFile rename tests, rename file into watched folder
Chris Howey [Fri, 2 Nov 2012 19:18:25 +0000 (14:18 -0500)]
File rename tests, rename file into watched folder

Two types:
Rename a file into folder where no file exists with that name.
Rename a file into a folder over a file with that name.

13 years agoLinux - Add IN_MOVED_TO by request, Issue #25
Chris Howey [Thu, 1 Nov 2012 23:20:07 +0000 (18:20 -0500)]
Linux - Add IN_MOVED_TO by request, Issue #25

13 years agoFix up delete watched directory test
Chris Howey [Thu, 1 Nov 2012 12:30:25 +0000 (07:30 -0500)]
Fix up delete watched directory test

13 years agoBSD - Fix for Issue #24 - Deleting watched directory
Chris Howey [Thu, 1 Nov 2012 12:12:29 +0000 (07:12 -0500)]
BSD - Fix for Issue #24 - Deleting watched directory

This fixes the issue where the delete of a watched directory sends and
error instead of a delete for the directory and the underlying watched
files.

The reproduce case for reference: https://gist.github.com/3972447

Also included is a test case addition for the above issue.

13 years agoGolang exp/inotify fixes
Chris Howey [Wed, 10 Oct 2012 00:23:22 +0000 (19:23 -0500)]
Golang exp/inotify fixes

http://code.google.com/p/go/issues/detail?id=3713
http://codereview.appspot.com/5418045/

13 years agoPreserve watch flags when watching for delete
Chris Howey [Tue, 9 Oct 2012 03:37:09 +0000 (22:37 -0500)]
Preserve watch flags when watching for delete

Fixes issue where adding a watch for a directory assumed that all
subdirectories can be watched for only delete. They should, but if they
are already watched we need to preserve the flags already set and add
delete watch.

Issue #21

13 years agoMerge branch 'master' of https://github.com/robfig/fsnotify
Chris Howey [Tue, 9 Oct 2012 03:11:44 +0000 (22:11 -0500)]
Merge branch 'master' of https://github.com/robfig/fsnotify

13 years agoWatch the directory even if it isn't a new watch.
Rob Figueiredo [Tue, 9 Oct 2012 02:36:22 +0000 (22:36 -0400)]
Watch the directory even if it isn't a new watch.

This fixes the issue where you watch directory and then its
subdirectory, the subdirectory does not have all its files watched (via
watchDirectoryFiles)

13 years agoTravis CI
Chris Howey [Tue, 9 Oct 2012 02:22:28 +0000 (21:22 -0500)]
Travis CI

13 years agoBSD - Fix recreate file test
Chris Howey [Tue, 9 Oct 2012 01:57:32 +0000 (20:57 -0500)]
BSD - Fix recreate file test

13 years agoRecreate test more precise
Chris Howey [Tue, 9 Oct 2012 01:55:25 +0000 (20:55 -0500)]
Recreate test more precise

13 years agoTest - Modify after recreation of file
Chris Howey [Tue, 9 Oct 2012 01:51:37 +0000 (20:51 -0500)]
Test - Modify after recreation of file

13 years agoAdditional test - recreate a file
Chris Howey [Tue, 9 Oct 2012 00:59:45 +0000 (19:59 -0500)]
Additional test - recreate a file

13 years agoBSD - Fix watch when there is an existing folder inside the watched folder
Kelvin Fo [Thu, 27 Sep 2012 15:22:56 +0000 (23:22 +0800)]
BSD - Fix watch when there is an existing folder inside the watched folder

13 years agoBSD - fix for subdir test
Chris Howey [Wed, 26 Sep 2012 01:11:20 +0000 (20:11 -0500)]
BSD - fix for subdir test

13 years agoBSD - fix to not longer get duplicate CREATE events
Chris Howey [Wed, 26 Sep 2012 00:57:52 +0000 (19:57 -0500)]
BSD - fix to not longer get duplicate CREATE events

needed to add DELETE watch for directories that are created in
watched directory

Also added a test for this behaviour

13 years agoBSD - Now receive events for created directories
Chris Howey [Sat, 1 Sep 2012 20:09:30 +0000 (15:09 -0500)]
BSD - Now receive events for created directories

13 years agoNew test - Receive event directory creation
Chris Howey [Sat, 1 Sep 2012 19:26:14 +0000 (12:26 -0700)]
New test - Receive event directory creation

13 years agoReadme notes
Chris Howey [Sat, 14 Jul 2012 19:18:47 +0000 (14:18 -0500)]
Readme notes

13 years agoWindows - Move file out of directory is a "DELETE"
Chris Howey [Sat, 14 Jul 2012 19:03:00 +0000 (14:03 -0500)]
Windows - Move file out of directory is a "DELETE"

Also, cannot move an open file, so test had to change.

13 years agoBSD - do not watch moved files (don't know new name)
Chris Howey [Sat, 14 Jul 2012 18:38:01 +0000 (13:38 -0500)]
BSD - do not watch moved files (don't know new name)

13 years agoLinux - fix to see create of file after rename
Chris Howey [Sat, 14 Jul 2012 18:30:49 +0000 (11:30 -0700)]
Linux - fix to see create of file after rename

13 years agoBSD - Fix for rename test case provided by snoe
Chris Howey [Sat, 14 Jul 2012 16:23:14 +0000 (11:23 -0500)]
BSD - Fix for rename test case provided by snoe

13 years agotest case that shows problems with dir watch on bsd
Case Nelson [Tue, 3 Jul 2012 21:17:25 +0000 (15:17 -0600)]
test case that shows problems with dir watch on bsd

13 years agoLinux - Added file name back to event path
Chris Howey [Tue, 3 Jul 2012 13:06:23 +0000 (06:06 -0700)]
Linux - Added file name back to event path

13 years agoBring example file back.
Chris Howey [Tue, 3 Jul 2012 00:56:53 +0000 (19:56 -0500)]
Bring example file back.

13 years agoWindows - FSNotify flags
Chris Howey [Tue, 3 Jul 2012 00:47:44 +0000 (19:47 -0500)]
Windows - FSNotify flags

13 years agoLinux - FSNotify flags
Chris Howey [Mon, 2 Jul 2012 23:52:42 +0000 (16:52 -0700)]
Linux - FSNotify flags

13 years agoBSD - FSNotify flags
Chris Howey [Mon, 2 Jul 2012 23:30:37 +0000 (18:30 -0500)]
BSD - FSNotify flags

13 years agoAdd link to GoDoc
Chris Howey [Fri, 8 Jun 2012 00:19:08 +0000 (19:19 -0500)]
Add link to GoDoc

13 years agoRemote watch on directory for attrib test so we don't get create for attrib file
Chris Howey [Fri, 8 Jun 2012 00:06:20 +0000 (19:06 -0500)]
Remote watch on directory for attrib test so we don't get create for attrib file

13 years agoChange bsd backend to watch files after triggering create events.
Travis Cline [Wed, 6 Jun 2012 19:55:38 +0000 (14:55 -0500)]
Change bsd backend to watch files after triggering create events.

13 years agoChange to expect a create event in DirOnly test.
Travis Cline [Wed, 6 Jun 2012 19:50:07 +0000 (14:50 -0500)]
Change to expect a create event in DirOnly test.

13 years agoFix example to use a goroutine for select.
Travis Cline [Tue, 5 Jun 2012 20:24:15 +0000 (15:24 -0500)]
Fix example to use a goroutine for select.

13 years agoConvert README to markdown
Chris Howey [Tue, 22 May 2012 15:06:41 +0000 (10:06 -0500)]
Convert README to markdown

13 years agoLinux - fix possible problem on Close()
Chris Howey [Tue, 22 May 2012 14:12:07 +0000 (07:12 -0700)]
Linux - fix possible problem on Close()

The Close() call should remove all watches BEFORE the call to close
the inotify instance.

13 years agoBSD - Return errors during watch instead of sending over channel
Chris Howey [Thu, 3 May 2012 22:48:30 +0000 (17:48 -0500)]
BSD - Return errors during watch instead of sending over channel

13 years agogo fmt
Chris Howey [Sat, 28 Apr 2012 16:29:58 +0000 (11:29 -0500)]
go fmt

13 years agoComment in README not valid, removed
Chris Howey [Sat, 28 Apr 2012 16:26:57 +0000 (11:26 -0500)]
Comment in README not valid, removed

13 years agoWindows - fix symlink test
Chris Howey [Sat, 28 Apr 2012 16:24:29 +0000 (11:24 -0500)]
Windows - fix symlink test

13 years agoWindows - No Symlinks
Chris Howey [Sat, 28 Apr 2012 16:21:04 +0000 (11:21 -0500)]
Windows - No Symlinks

13 years agoBSD - Have symlink behavior match Linux
Chris Howey [Sat, 28 Apr 2012 16:06:35 +0000 (11:06 -0500)]
BSD - Have symlink behavior match Linux

13 years agoBSD - Added fake symlink test
Chris Howey [Sat, 28 Apr 2012 15:51:46 +0000 (10:51 -0500)]
BSD - Added fake symlink test

13 years agoLinux - Added DELETE_SELF, noticed by taralx
Chris Howey [Tue, 17 Apr 2012 23:17:30 +0000 (16:17 -0700)]
Linux - Added DELETE_SELF, noticed by taralx

13 years agoMerge pull request #1 from davecheney/master
Chris Howey [Wed, 4 Apr 2012 22:50:30 +0000 (15:50 -0700)]
Merge pull request #1 from davecheney/master

Godoc example

13 years agoBSD - fix for rob (EINTR)
Chris Howey [Wed, 4 Apr 2012 22:44:59 +0000 (17:44 -0500)]
BSD - fix for rob (EINTR)

13 years agoFix example name
Dave Cheney [Wed, 4 Apr 2012 10:41:22 +0000 (20:41 +1000)]
Fix example name

13 years agoI should run go test -v before commiting
Dave Cheney [Wed, 4 Apr 2012 10:39:16 +0000 (20:39 +1000)]
I should run go test -v before commiting

13 years agoRemove duplicate example code
Dave Cheney [Wed, 4 Apr 2012 10:22:38 +0000 (20:22 +1000)]
Remove duplicate example code

13 years agoAdd godoc example
Dave Cheney [Wed, 4 Apr 2012 10:16:21 +0000 (20:16 +1000)]
Add godoc example

13 years agoBSD - Fix issue reported by robfig
Chris Howey [Wed, 4 Apr 2012 03:24:59 +0000 (22:24 -0500)]
BSD - Fix issue reported by robfig

EINTR can be returned by kevent in two cases:
1) fork() while parent/child is calling kevent() will result in the
process calling kevent() to get EINTR while other process is registering
the same kqueue at the kernel level.
2) A file event occurs before timeout expires, but is not yet on the
queue to be returned by kevent().

In either case, we can ignore the error and continue as if timeout
expired without any events.

13 years agoUpdate readme with status
Chris Howey [Sat, 31 Mar 2012 00:10:28 +0000 (19:10 -0500)]
Update readme with status

13 years agoBSD - roll attribute into modify
Chris Howey [Sat, 31 Mar 2012 00:09:12 +0000 (19:09 -0500)]
BSD - roll attribute into modify

13 years agoLinux - roll attribute into modify
Chris Howey [Sat, 31 Mar 2012 00:05:19 +0000 (17:05 -0700)]
Linux - roll attribute into modify

13 years agoWindows - roll attributes into notify
Chris Howey [Sat, 31 Mar 2012 00:00:57 +0000 (19:00 -0500)]
Windows - roll attributes into notify

13 years agoWindows does not support attribute notifications - See README
Chris Howey [Fri, 30 Mar 2012 20:54:12 +0000 (15:54 -0500)]
Windows does not support attribute notifications - See README

13 years agoWindows - Missed a line
Chris Howey [Thu, 29 Mar 2012 15:42:04 +0000 (10:42 -0500)]
Windows - Missed a line

13 years agoWindows Issue - No attribute change notifications
Chris Howey [Thu, 29 Mar 2012 00:03:48 +0000 (19:03 -0500)]
Windows Issue - No attribute change notifications

13 years agoGo 1 Released - Updated
Chris Howey [Wed, 28 Mar 2012 22:45:27 +0000 (15:45 -0700)]
Go 1 Released - Updated

Now uses go tool
Also added windows support by using winfsnotify

13 years agoBSD - Add files when watch directory
Chris Howey [Sun, 19 Feb 2012 22:00:38 +0000 (16:00 -0600)]
BSD - Add files when watch directory

13 years agotest fix
Chris Howey [Sun, 19 Feb 2012 21:32:19 +0000 (13:32 -0800)]
test fix

13 years agoLinux, update to latest weekly Go
Chris Howey [Sat, 31 Dec 2011 05:04:51 +0000 (21:04 -0800)]
Linux, update to latest weekly Go

13 years agoUpdated to latest go weekly code
Chris Howey [Sat, 31 Dec 2011 04:45:46 +0000 (22:45 -0600)]
Updated to latest go weekly code

14 years agoBSD change
Chris Howey [Thu, 20 Oct 2011 01:07:14 +0000 (18:07 -0700)]
BSD change

14 years agoBSD: timing issues
Chris Howey [Thu, 20 Oct 2011 01:02:06 +0000 (18:02 -0700)]
BSD: timing issues

14 years agoTests only count what we care about, nothing else
Chris Howey [Wed, 19 Oct 2011 23:48:33 +0000 (16:48 -0700)]
Tests only count what we care about, nothing else

14 years agoTests based on receiving events we want
Chris Howey [Wed, 19 Oct 2011 23:43:27 +0000 (16:43 -0700)]
Tests based on receiving events we want

14 years agoBSD Test: Change placement of watch for attrib
Chris Howey [Wed, 19 Oct 2011 23:23:58 +0000 (16:23 -0700)]
BSD Test: Change placement of watch for attrib

14 years agoLinux test: need to watch file for rename
Chris Howey [Wed, 19 Oct 2011 23:21:26 +0000 (16:21 -0700)]
Linux test: need to watch file for rename

14 years agoBSD Test: Need to use outside program to trigger some events
Chris Howey [Wed, 19 Oct 2011 23:17:45 +0000 (16:17 -0700)]
BSD Test: Need to use outside program to trigger some events

14 years agoBSD: pass on errors
Chris Howey [Tue, 18 Oct 2011 12:56:03 +0000 (05:56 -0700)]
BSD: pass on errors