From: Martin Tournoij <martin@arp242.net>
Date: Sat, 15 Oct 2022 20:58:27 +0000 (+0200)
Subject: Actually, just return the first error
X-Git-Tag: v1.7.2~36
X-Git-Url: https://go.fuhry.dev/?a=commitdiff_plain;h=06c044ba7d8c251267e3df682f394cfc3cc9217b;p=fsnotify.git

Actually, just return the first error

Now I got thousands of:

    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor

That's not helpful.
---

diff --git a/helpers_test.go b/helpers_test.go
index 7f1de52..00f3bf4 100644
--- a/helpers_test.go
+++ b/helpers_test.go
@@ -382,6 +382,8 @@ func (w *eventCollector) collect(t *testing.T) {
 					return
 				}
 				t.Error(e)
+				w.done <- struct{}{}
+				return
 			case e, ok := <-w.w.Events:
 				if !ok {
 					w.done <- struct{}{}