]> go.fuhry.dev Git - fsnotify.git/commitdiff
Don't return in collect test helper on errors
authorMartin Tournoij <martin@arp242.net>
Sat, 15 Oct 2022 20:54:04 +0000 (22:54 +0200)
committerMartin Tournoij <martin@arp242.net>
Sat, 15 Oct 2022 20:54:04 +0000 (22:54 +0200)
Would return without calling close, so on errors you'd get a meaningless
"event stream was not closed after 1s":

--- FAIL: TestWatchRm (0.00s)
--- FAIL: TestWatchRm/remove_watched_directory (2.43s)
helpers_test.go:384: fsnotify.sendDirectoryChangeEvents: open /tmp/TestWatchRmremove_watched_directory2304249565/001: no such file or directory
helpers_test.go:354: event stream was not closed after 1s

helpers_test.go

index 22bb6dfe7f2eb0e274996c99990d940b189fbf85..7f1de528dd3dc0c3b87072a6f1d4f57db9d63618 100644 (file)
@@ -382,7 +382,6 @@ func (w *eventCollector) collect(t *testing.T) {
                                        return
                                }
                                t.Error(e)
-                               return
                        case e, ok := <-w.w.Events:
                                if !ok {
                                        w.done <- struct{}{}