[#234] t.Fatalf -> t.Errorf in go routines (#266)

The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.

diff --git a/integration_darwin_test.go b/integration_darwin_test.go
index cd6adc273e19611e50560465b6e28c18f0f41e5e..553767c3896fb65e48e4e06b542bd9de9ba704ed 100644 (file)
--- a/integration_darwin_test.go
+++ b/integration_darwin_test.go
@@ -55,7 +55,7 @@ func testExchangedataForWatcher(t *testing.T, watchDir bool) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 

diff --git a/integration_test.go b/integration_test.go
index 8b7e9d3ec8144b177369155bd3951d8fe705e881..7096344d5b4ad8149607777ac4cb954b670520fa 100644 (file)
--- a/integration_test.go
+++ b/integration_test.go
@@ -194,7 +194,7 @@ func TestFsnotifyMultipleCreates(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -339,7 +339,7 @@ func TestFsnotifyDirOnly(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -444,7 +444,7 @@ func TestFsnotifyDeleteWatchedDir(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -489,7 +489,7 @@ func TestFsnotifySubDir(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -581,7 +581,7 @@ func TestFsnotifyRename(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -663,7 +663,7 @@ func TestFsnotifyRenameToCreate(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -756,7 +756,7 @@ func TestFsnotifyRenameToOverwrite(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()
 
@@ -874,7 +874,7 @@ func TestFsnotifyAttrib(t *testing.T) {
        // Receive errors on the error channel on a separate goroutine
        go func() {
                for err := range watcher.Errors {
-                       t.Fatalf("error received: %s", err)
+                       t.Errorf("error received: %s", err)
                }
        }()