]> go.fuhry.dev Git - fsnotify.git/commit
projects / fsnotify.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ee33a65) | patch
windows: run TestWatchRename/rename_overwriting_existing_file (#490)
authorMartin Tournoij <martin@arp242.net>
Fri, 5 Aug 2022 19:52:45 +0000 (21:52 +0200)
committerGitHub <noreply@github.com>
Fri, 5 Aug 2022 19:52:45 +0000 (21:52 +0200)
commitf45391f620d5d2c9a8dfc22395951e06859bcb6c
treeb0fab29a27e5a4e4ae19c17a0f8871c4d7f97ddbtree | snapshot (tar.gz zip)
parentee33a655c06adcd00538cb9fb3d9fc5d8a727f42commit | diff
windows: run TestWatchRename/rename_overwriting_existing_file (#490)

This Skip() was added in 2013 (c825c6d) with "Windows cannot overwrite
file on rename", but it seems to work fine. os.Rename() is also
documented as "If newpath already exists and is not a directory, Rename
replaces it", so if it *doesn't* work it's a bug in os.Rename(). Maybe
os.Rename() behaved different nine years ago.
inotify.go diff | blob | history
integration_test.go diff | blob | history