]> go.fuhry.dev Git - fsnotify.git/commit
Move some inotify-tests to run on all backends; test that state is cleaned up after...
authorMartin Tournoij <martin@arp242.net>
Mon, 8 Aug 2022 13:56:08 +0000 (15:56 +0200)
committerGitHub <noreply@github.com>
Mon, 8 Aug 2022 13:56:08 +0000 (15:56 +0200)
commite180a87abd14c3ba3929d07273989b5ab913ea18
tree47832342ef3ad853fba4fbec1aec1a7bfe41465d
parentfdf41a303e4f147cde32bbb3e813f04551cd76f3
Move some inotify-tests to run on all backends; test that state is cleaned up after Remove (#494)

This moves a number of tests from backend_inotify_test.go to
fsnotify_test.go, as they're not really inotify-specific. In particular,
it moves the "stress test", which creates a bunch of events/files. It
also expands this test to (potentially) create many more than just 1,000
files, depending on how many the system will allow.

Unfortunately these tests seem pretty flaky on kqueue platforms, where
they're allowed to fail for now (failing the test won't fail the test
run). This seems to expose some existing limits/problems that need to
fixed in a future PR.

Also test that the internal state is cleaned up with TestRemoveState().
The Windows backend doesn't have a test for it (or rather, it doesn't
run) as it *doesn't* clean the state properly, but I found it too
confusing to fix ðŸ¤· Need to spend some time on that in the future.

Reorder/rename some GitHub Actions test runs to show nicer in the UI.

Fixes #42
Fixes #268
15 files changed:
.github/workflows/test.yml
.github/workflows/vagrant.yml [deleted file]
.gitignore
CONTRIBUTING.md
backend_inotify.go
backend_inotify_test.go
backend_kqueue.go
backend_kqueue_test.go [new file with mode: 0644]
backend_windows.go
backend_windows_test.go [new file with mode: 0644]
fsnotify_test.go
helpers_test.go
internal/darwin.go [new file with mode: 0644]
internal/unix.go
internal/windows.go