]> go.fuhry.dev Git - fsnotify.git/commit
Fix possible deadlock on closing the watcher on kqueue (#230)
authorAnmol Sethi <me@anmol.io>
Wed, 10 Jan 2018 04:19:26 +0000 (23:19 -0500)
committerNathan Youngman <git@nathany.com>
Wed, 10 Jan 2018 04:19:26 +0000 (21:19 -0700)
commit3d33f50bcfa97a7cb7e7583a200dde7928dfc262
treecba68b4ce7abec405b9b7bf24f17fa1d02828457
parent4da3e2cfbabc9f751898f250b49f2439785783a1
Fix possible deadlock on closing the watcher on kqueue (#230)

* avoid deadlocks on Close()

raw channel work (not inside a select) should
always be prohibited in production code, as
it readily causes deadlocks on shutdown.

Also adds the test TestWatcherClose from #145.
This request duplicates that test, with two
lines fixed to address the houndcli-bot review
concerns.

Fixes #187
Fixes #145

* cleanup and simpler test

* also fix #225

* fix tests
fsnotify_test.go
kqueue.go